-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flatten command field types for the jsonpacker #130
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
=======================================
Coverage 83.85% 83.86%
=======================================
Files 34 34
Lines 3487 3489 +2
=======================================
+ Hits 2924 2926 +2
Misses 563 563
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks for your contribution, we will look at the changes later. But for now, could you maybe create an issue and attach it to this PR? It would make keeping track of issues a lot easier for us. |
Do you have an update for us regarding this pull request @Miauwkeru? |
Hi @JSCU-CNI , |
This PR flattens the field type
command
in the JSON packer and fixes #132.Currently the
dissect.target
project is inconsistent in using the same field namecommand
and the new field typecommand
. This patch makes it possible to upload and aggregate on different records in Elasticsearch with the field namecommand
and differing field types.For example, see
RunKeysPlugin.runkeys
andPowerShellHistoryPlugin.powershell_history
.You could argue (and we agree) that this should be fixed in
dissect.target
as allRecordDescriptor
s currently using("string", "command")
should perhaps use the newcommand
record type. That makes sense to do in the long run. Perhaps a field calledfull
could be added to the standard output of thecommand
fieldtype dict to still be able to index the full, original, command.Historically the
command
field type introduced a backwards incompatible change into dissect. This PR fixes that inconsistency.