Use non-dev dependencies in pyproject.toml #124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narimantos
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #124 +/- ##
==========================================
+ Coverage 83.76% 84.61% +0.84%
==========================================
Files 34 34
Lines 3413 3413
==========================================
+ Hits 2859 2888 +29
+ Misses 554 525 -29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
narimantos
force-pushed
the
tox-testenv-pre
branch
from
3db9e56 to
e3cd4ed
Compare
yunzheng
reviewed
May 28, 2024
| @@ -16,6 +16,13 @@ deps = | |||
| pytest-cov | |||
| coverage | |||
| extras = test | |||
There was a problem hiding this comment.
i think the extras can be removed here then?
yunzheng
reviewed
May 28, 2024
Comment on lines
+24
to
+25
| commands_pre = | ||
| pip install --pre -e .[test] |
There was a problem hiding this comment.
It's also possible to list the flags and package extra under [deps] like so:
[testenv]
deps =
pytest
pytest-cov
coverage
--pre --editable .[test]
Then you don't have to run the pip command separately.
|
We decided to drop this PR because flow.record doesn't have any Dissect dependencies. With the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fox-it/dissect#61