Add vinum volume/raid support #41
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
==========================================
+ Coverage 72.29% 76.70% +4.40%
==========================================
Files 26 29 +3
Lines 1960 2365 +405
==========================================
+ Hits 1417 1814 +397
- Misses 543 551 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pyrco
force-pushed
the
add-vinum-support
branch
2 times, most recently
from
3816c17 to
204f045
Compare
pyrco
force-pushed
the
add-vinum-support
branch
from
204f045 to
1d156d3
Compare
| of multiple belonging to the same RAID set. | ||
| """ | ||
|
|
||
| def __init__(self, fh: list[VinumPhysicalDiskDescriptor] | VinumPhysicalDiskDescriptor): |
There was a problem hiding this comment.
fh can also be a BinaryIO I think?
There was a problem hiding this comment.
Yes, it can be. VinumPhysicalDiskDescriptor is currently defined as BinaryIO | "VinumPhysicalDisk".
| else: | ||
| log.warning("Plex %r has an unknown organistaion, ignoring plex", plex.name) | ||
| else: | ||
| log.warning("Plex %r is down, ignoring plex", plex.name) |
There was a problem hiding this comment.
What does it mean when a plex is "down"? In the case of Dissect, would it not still be interesting to "open" "down" plexes?
There was a problem hiding this comment.
I'm not sure how "broken" Plexes are that are down. If we do try to use them it could especially interfere with mirrored sets where one of the mirrors is still up/correct.
dissect/volume/vinum/vinum.py
Outdated
| class Vinum(RAID): | ||
| """Read a Vinum RAID set of one or multiple devices/file-like objects. | ||
|
|
||
| Use this class to read from a RAID set. |
There was a problem hiding this comment.
Can you use this docstring to shortly explain what all the nomenclature means? E.g. what's a plex, what's a "SD", or organisation?
This is probably the most relevant/easily findable class to do it in.
pyrco
force-pushed
the
add-vinum-support
branch
from
1d156d3 to
e1c21b9
Compare
No description provided.