Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey FZ,
I noticed your Darwin "is_heap" implementation filtered based on !is_stack && !is_code.
I've worked up a implementation which enumerates the zones using XNU's malloc introspection APIs. This will hopefully give more performant and accurate analysis.
I need to verify this does in fact give all heap regions as some valid pointers (such as where heap zones metadata) are not found, which is somewhat suspicious. However, I thought it best to open this up for you guys to review asap.
Thanks,
Robert