Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect gas estimation on Sonic w/ forge script #9739

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

zerosnacks
Copy link
Member

@zerosnacks zerosnacks commented Jan 22, 2025

Motivation

Closes: #9723

Solution

Previously (as reported), scaling up dramatically near the end:

cat broadcast/Test.s.sol/146/run-latest.json | grep -c '"gas": "0x1502be"'
61

Now (estimation is correct):

cat broadcast/Test.s.sol/146/run-latest.json | grep -c '"gas": "0x1502be"'
100

@zerosnacks zerosnacks changed the title fix: incorrect gas estimation sonic w/ forge script fix: incorrect gas estimation on Sonic w/ forge script Jan 22, 2025
Cargo.lock Show resolved Hide resolved
@grandizzy grandizzy added T-bug Type: bug C-forge Command: forge labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-forge Command: forge T-bug Type: bug
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Incorrect forge script gas estimation on Sonic
3 participants