Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a make target with script to set version in corresponding files #211

Open
sunya-ch opened this issue Jan 17, 2025 · 1 comment
Open
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@sunya-ch
Copy link
Collaborator

sunya-ch commented Jan 17, 2025

Currently we manually increase the version on main.

Example PRs for increment of v1.2.4:

These PRs include changes in

  • .github/workflows - for build/push image in main branch and for tests in patch of specific branch version
  • Makefile
  • README
  • config/manager/kustomization.yaml
  • config/samples/config.yaml
  • config/samples/kustomization.yaml
  • daemon/Makefile
  • daemon/dockerfiles/Dockerfile.kbuilder
  • connection-check/concheck.yaml
  • controllers/vars/vars.go - for default multi-nicd image

We must have a file VERSION to keep the current version.
Then, we would like to have a script to update the version and edit the above files with a single command like make set-version.

@sunya-ch sunya-ch added the enhancement New feature or request label Jan 17, 2025
@sunya-ch sunya-ch changed the title make target for increase version add a make target with script to increase version in corresponding files Feb 4, 2025
@sunya-ch sunya-ch changed the title add a make target with script to increase version in corresponding files add a make target with script to set version in corresponding files Feb 4, 2025
@sunya-ch sunya-ch added this to the v1.2.6 milestone Feb 6, 2025
@sunya-ch
Copy link
Collaborator Author

sunya-ch commented Feb 7, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants