Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Merge in changes for v2.5.0 release #453

Merged
merged 16 commits into from
Jan 27, 2025
Merged

Conversation

aluu317
Copy link
Collaborator

@aluu317 aluu317 commented Jan 27, 2025

Description of the change

Related issue number

How to verify the PR

Was the PR tested

  • I have added >=1 unit test(s) for every new method I have added.
  • I have ensured all unit tests pass

willmj and others added 15 commits January 17, 2025 14:21
* docs: EOS token support

Signed-off-by: Will Johnson <mwjohnson728@gmail.com>

* Update README.md

Co-authored-by: Sukriti Sharma <Ssukriti@users.noreply.github.com>
Signed-off-by: Will Johnson <mwjohnson728@gmail.com>

---------

Signed-off-by: Will Johnson <mwjohnson728@gmail.com>
Co-authored-by: Sukriti Sharma <Ssukriti@users.noreply.github.com>
Signed-off-by: Angel Luu <angel.luu@us.ibm.com>
Signed-off-by: Angel Luu <angel.luu@us.ibm.com>
Signed-off-by: Angel Luu <angel.luu@us.ibm.com>
Signed-off-by: Angel Luu <angel.luu@us.ibm.com>
Signed-off-by: Angel Luu <angel.luu@us.ibm.com>
Signed-off-by: Angel Luu <angel.luu@us.ibm.com>
…ta path (#447)

* docs: add note to note that file extension is required in training data path

Signed-off-by: Will Johnson <mwjohnson728@gmail.com>

* docs: clarify what is being checked

Signed-off-by: Will Johnson <mwjohnson728@gmail.com>

* docs: make note, clarification

Signed-off-by: Will Johnson <mwjohnson728@gmail.com>

* docs: clarify specifically what code does

Signed-off-by: Will Johnson <mwjohnson728@gmail.com>

---------

Signed-off-by: Will Johnson <mwjohnson728@gmail.com>
Signed-off-by: Dushyant Behl <dushyantbehl@in.ibm.com>
Signed-off-by: Anh Uong <anh.uong@ibm.com>
Co-authored-by: Will Johnson <mwjohnson728@gmail.com>
Signed-off-by: Anh Uong <anhuong4444@gmail.com>
Copy link

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@github-actions github-actions bot added the chore label Jan 27, 2025
Copy link
Collaborator

@anhuong anhuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good -- note that the scanner tracker and python bump PRs were merged in as merge commits instead of squash commits. Please sign last commit and wait for tests to run, otherwise LGTM

chore: bump python version
Signed-off-by: Angel Luu <angel.luu@us.ibm.com>
@aluu317 aluu317 merged commit 6f9bab2 into release Jan 27, 2025
10 checks passed
@aluu317 aluu317 deleted the 2_5_release_prep branch January 27, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants