Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-9618: Move I18n shim to core #6042

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

FIO-9618: Move I18n shim to core #6042

wants to merge 3 commits into from

Conversation

blakekrammes
Copy link
Contributor

  • Move relevant translation strings to core

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9618

Description

What changed?

As part of the move to render emails in a core processor instead of formio.js, it was necessary to enable I18n translation in core, thus moving the shim from here to there. Since translation is not directly related to rendering formio components it was deemed fitting to move this to core. I have also moved relevant translation strings to core (many of the errors were already present there and have been removed here). The translations left in formio.js should only relate to frontend concerns.

Why have you chosen this solution?

Use this section to justify your choices

Breaking Changes / Backwards Compatibility

Use this section to describe any potentially breaking changes this PR introduces or any effects this PR might have on backwards compatibility

Dependencies

Use this section to list any dependent changes/PRs in other Form.io modules

How has this PR been tested?

Manually

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

- Move relevant translation strings to core
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant