Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-9515 Fixed Edit grid conditional values not displayed in Edit sub… #5988

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

antonSoftensity
Copy link
Contributor

@antonSoftensity antonSoftensity commented Jan 21, 2025

…mission

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9515

Description

After changes to clearOnHide behavior, process of determining whether to clear the value of a component changed to the way so that when the form was initially loaded, component that were just rendered were compared with their own previous state, as if they were interacted with already, which is not a correct behavior. The check to see if the form is pristine was added, because clearOnHide function should not fire when the form is in fact pristine.

Added a condition so that we don't check each component visibility when the root is pristine, so that value can be deleted only on EditGrid data level when it is hidden/shown

Breaking Changes / Backwards Compatibility

Dependencies

How has this PR been tested?

Tested locally. All the tests for clearOnHide pass, so this is not a breaking change.

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants