Skip to content

Commit

Permalink
FIO-8372 fixed setting date after selecting and erasing entire date
Browse files Browse the repository at this point in the history
  • Loading branch information
HannaKurban committed Jan 15, 2025
1 parent 7cbee3b commit b1aad89
Show file tree
Hide file tree
Showing 2 changed files with 43 additions and 14 deletions.
14 changes: 0 additions & 14 deletions src/widgets/CalendarWidget.js
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,6 @@ export default class CalendarWidget extends InputWidget {
this.settings.disableWeekends ? this.settings.disable.push(this.disableWeekends) : '';
this.settings.disableWeekdays ? this.settings.disable.push(this.disableWeekdays) : '';
this.settings.disableFunction ? this.settings.disable.push(this.disableFunction) : '';
this.settings.wasDefaultValueChanged = false;
this.settings.defaultValue = '';
this.settings.manualInputValue = '';
this.settings.isManuallyOverriddenValue = false;
this.settings.currentValue = '';
Expand All @@ -138,10 +136,6 @@ export default class CalendarWidget extends InputWidget {
this.emit('update');
}

if (this.settings.wasDefaultValueChanged) {
this.calendar._input.value = this.settings.defaultValue;
this.settings.wasDefaultValueChanged = false;
}
if (this.calendar) {
this.emit('blur');
}
Expand Down Expand Up @@ -425,14 +419,6 @@ export default class CalendarWidget extends InputWidget {
this.settings.currentValue = event.target.value;
this.emit('update');
}

if (event.target.value === '' && this.calendar.selectedDates.length > 0) {
this.settings.wasDefaultValueChanged = true;
this.settings.defaultValue = event.target.value;
this.calendar.clear();
} else {
this.settings.wasDefaultValueChanged = false;
}
});
if(this.calendar.daysContainer) {
this.calendar.daysContainer.addEventListener('click', () => {
Expand Down
43 changes: 43 additions & 0 deletions test/unit/DateTime.unit.js
Original file line number Diff line number Diff line change
Expand Up @@ -772,6 +772,49 @@ describe('DateTime Component', () => {
})
});

it('Should set Value after erasing entire data and setting new one', (done) => {
const form = _.cloneDeep(comp3);
const element = document.createElement('div');
form.components[0].enableTime = false;

Formio.createForm(element, form).then(form => {
const dateTime = form.getComponent('dateTime');
const calendar = dateTime.element.querySelector('.flatpickr-input').widget.calendar;
const input = dateTime.element.querySelector('.input');
calendar.altInput.click();

setTimeout(()=> {
calendar.altInput.value = '2025-01-01';
calendar._input.value = '2025-01-01';
const inputEvent = new Event('input');
calendar.altInput.dispatchEvent(inputEvent);
setTimeout(() => {
calendar.setDate(calendar._input.value, false, calendar.config.altFormat);
calendar.close();
assert.equal(input.value, '2025-01-01');
input.value = '';
input.dispatchEvent(inputEvent);
setTimeout(()=> {
assert.equal(input.value, '');
calendar.altInput.click();
setTimeout(() => {
calendar.altInput.value = '2025-02-02';
calendar._input.value = '2025-02-02';
calendar.altInput.dispatchEvent(inputEvent);
setTimeout(() => {
calendar.setDate(calendar._input.value, false, calendar.config.altFormat);
calendar.close();
assert.equal(input.value, '2025-02-02');
document.innerHTML = '';
done();
}, 200);
}, 200);
}, 200);
}, 200);
}, 200);
}).catch(done);
});

it('Should preserve the calendar widget settings after field logic is evaluated', async () => {
// see https://formio.atlassian.net/browse/FIO-9385
// emulate viewing a submission in the portal with { readOnly: true }
Expand Down

0 comments on commit b1aad89

Please sign in to comment.