Email subject template instead of hardcoded string #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of a direct setting, the email subject can now be set using a template. This is heavily inspired and pretty much copied from the way Django is rendering the email subject for its password reset links. See https://github.com/django/django/blob/main/django/contrib/auth/templates/registration/password_reset_subject.txt See https://docs.djangoproject.com/en/4.2/topics/auth/default/#django.contrib.auth.views.PasswordResetView.subject_template_name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of a direct setting, the email subject can now be set using a template.
This is heavily inspired and pretty much copied from the way Django is rendering the email subject for its password reset links.
See https://github.com/django/django/blob/main/django/contrib/auth/templates/registration/password_reset_subject.txt
See https://docs.djangoproject.com/en/4.2/topics/auth/default/#django.contrib.auth.views.PasswordResetView.subject_template_name
This approach also allows for a i18n email subject, which is not really possible otherwise (gettext translations in settings will likely break email services).