vttclean is now merged into unwanted_tables

(issue #4975)
fonttools · Jan 17, 2025 · 9eddd77 · 9eddd77
1 parent 865798a
commit 9eddd77
Show file tree

Hide file tree

Showing 12 changed files with 8 additions and 51 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,7 +6,7 @@ A more detailed list of changes is available in the corresponding milestones for
 
 ### Changes to existing checks
 ### On the Universal profile.
-  - **[no_debugging_tables]:** merged into unwanted_tables. (issue #4972)
+  - **[no_debugging_tables]** and **[vttclean]** are now merged into unwanted_tables. (issues #4972 and #4975)
 
 ### On the OpenType Profile
   - **[opentype/slant_direction]:** SKIP instead of ERROR if a font does not contain 'H' (PR #4969)

diff --git a/Lib/fontbakery/checks/vtt_volt_data.py b/Lib/fontbakery/checks/vtt_volt_data.py
@@ -1,8 +1,6 @@
 from fontbakery.prelude import check, FAIL, PASS
 
 
-# FIXME: I think these two checks ('vtt_volt_data' and 'vttclean') are very similar
-#        so we may consider merging them into a single one.
 @check(
     id="vtt_volt_data",
     rationale="""

diff --git a/Lib/fontbakery/checks/vttclean.py b/Lib/fontbakery/checks/vttclean.py
diff --git a/Lib/fontbakery/legacy_checkids.py b/Lib/fontbakery/legacy_checkids.py
@@ -329,7 +329,7 @@
     "com.google.fonts/check/varfont/instances_in_order":                    "varfont/instances_in_order",
     "com.google.fonts/check/varfont/unsupported_axes":                      "varfont/unsupported_axes",
     "com.microsoft/check/vtt_volt_data":                                    "vtt_volt_data",
-    "com.google.fonts/check/vttclean":                                      "vttclean",
+    "com.google.fonts/check/vttclean":                                      "unwanted_tables",
     "com.google.fonts/check/whitespace_glyphs":                             "whitespace_glyphs",
     "com.google.fonts/check/whitespace_ink":                                "whitespace_ink",
     "com.google.fonts/check/whitespace_widths":                             "whitespace_widths",

diff --git a/Lib/fontbakery/profiles/adobefonts.py b/Lib/fontbakery/profiles/adobefonts.py
@@ -82,8 +82,7 @@
         "varfont/duplexed_axis_reflow",
         "varfont/instances_in_order",
         "varfont/unsupported_axes",
-        "vtt_volt_data",  # very similar to vttclean, may be a good idea to merge them.
-        "vttclean",
+        "vtt_volt_data",
     ],
     "sections": {
         "Adobe Fonts Checks": [

diff --git a/Lib/fontbakery/profiles/fontbureau.py b/Lib/fontbakery/profiles/fontbureau.py
@@ -34,8 +34,7 @@
         "varfont/duplicate_instance_names",
         "varfont/instances_in_order",
         "varfont/unsupported_axes",
-        "vtt_volt_data",  # very similar to vttclean, may be a good idea to merge them.
-        "vttclean",
+        "vtt_volt_data",
     ],
     "sections": {
         "Font Bureau Checks": [

diff --git a/Lib/fontbakery/profiles/fontwerk.py b/Lib/fontbakery/profiles/fontwerk.py
@@ -21,7 +21,7 @@
         "googlefonts/axes_match",
         "overlapping_path_segments",
         "typographic_family_name",
-        "vtt_volt_data",  # very similar to vttclean, may be a good idea to merge them.
+        "vtt_volt_data",
         #
         # Note: When reviewing these 2 checks below, please check whether googlefonts also includes them or not,
         # since currently they're in googlefonts' pending_review as well.

diff --git a/Lib/fontbakery/profiles/googlefonts.py b/Lib/fontbakery/profiles/googlefonts.py
@@ -7,7 +7,7 @@
         "inconsistencies_between_fvar_STAT",
         "no_mac_entries",
         "typographic_family_name",
-        "vtt_volt_data",  # very similar to vttclean, may be a good idea to merge them.
+        "vtt_volt_data",
     ],
     "sections": {
         "Article Checks": [

diff --git a/Lib/fontbakery/profiles/microsoft.py b/Lib/fontbakery/profiles/microsoft.py
@@ -53,7 +53,6 @@
         "varfont/duplicate_instance_names",
         "varfont/instances_in_order",
         "varfont/unsupported_axes",
-        "vttclean",  # very similar to vtt_volt_data, may be a good idea to merge them.
     ],
     "sections": {
         "Metadata Checks": [

diff --git a/Lib/fontbakery/profiles/typenetwork.py b/Lib/fontbakery/profiles/typenetwork.py
@@ -34,7 +34,7 @@
         "ufo_recommended_fields",  #              <
         "ufo_required_fields",  #                 <
         "ufo_unnecessary_fields",  #              <
-        "vtt_volt_data",  # Very similar to 'vttclean' check, it may be a good idea to merge them.
+        "vtt_volt_data",
         "varfont/unsupported_axes",  # Despite discouraging its use, TN accepts fonts with ital axis.
     ],
     "pending_review": [

diff --git a/Lib/fontbakery/profiles/universal.py b/Lib/fontbakery/profiles/universal.py
@@ -91,8 +91,7 @@
             "varfont/duplicate_instance_names",
             "varfont/instances_in_order",
             "varfont/unsupported_axes",
-            "vtt_volt_data",  # very similar to vttclean, may be a good idea to merge them.
-            "vttclean",
+            "vtt_volt_data",
             "whitespace_glyphs",
             "whitespace_ink",
             "whitespace_widths",

diff --git a/tests/test_checks_hinting.py b/tests/test_checks_hinting.py
@@ -58,14 +58,3 @@ def test_check_smart_dropout(check):
 
     ttFont["prep"].program.bytecode = array.array("B", [0])
     assert_results_contain(check(ttFont), FAIL, "lacks-smart-dropout")
-
-
-@check_id("vttclean")
-def test_check_vttclean(check):
-    """There must not be VTT Talk sources in the font."""
-
-    good_font = TEST_FILE("mada/Mada-Regular.ttf")
-    assert_PASS(check(good_font))
-
-    bad_font = TEST_FILE("hinting/Roboto-VF.ttf")
-    assert_results_contain(check(bad_font), FAIL, "has-vtt-sources")