STCOR-942: migrate away from reading stripes-config::okapi.url #1589
+164
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bigtest Unit Test Results189 tests ±0 184 ✅ ±0 6s ⏱️ ±0s Results for commit 90bcd74. ± Comparison against base commit c800a5a. This pull request removes 5 and adds 3 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
zburke
approved these changes
Feb 13, 2025
src/loginServices.js
Outdated
Comment on lines
882
to
890
| if (store.getState().okapi.authnUrl) { | ||
| return fetch(store.getState().okapi.authnUrl, { | ||
| method: 'POST', | ||
| body: new URLSearchParams({ | ||
| ...data, | ||
| 'grant_type': 'password', | ||
| 'client_id': okapi.clientId, | ||
| 'client_secret': okapi.clientSecret, | ||
| 'client_id': store.getState()?.okapi?.clientId, | ||
| }) | ||
| }) |
There was a problem hiding this comment.
In fact this whole conditional is irrelevant, left-over from a very early implementation. Now, when okapi.authnUrl is present, we redirect to Keycloak to authenticate, meaning we don't need a conditional at all because requestLogin is only called in legacy context.
|
zburke
added a commit
that referenced
this pull request
Feb 14, 2025
Fetch `tenant` from state instead of from `stripes-config`. This resolves a bug introduced in #1589 that left a dangling reference to `this.tenant` that was no longer populated. Refs STCOR-942
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs STCOR-942.