Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish Translation #380

Closed
strusik01 opened this issue Dec 26, 2024 · 19 comments · Fixed by #396
Closed

Polish Translation #380

strusik01 opened this issue Dec 26, 2024 · 19 comments · Fixed by #396
Labels
question Further information is requested
Milestone
3.21

Comments

@strusik01
Copy link
Contributor

Hello, I'm wondering if the app will be translated any time soon? I can see some languages covered, polish included which is the one I'm most interested with, although it's not implemented yet.
@strusik01 strusik01 added the question Further information is requested label Dec 26, 2024
@fmasa
Copy link
Owner

fmasa commented Dec 31, 2024

I just enabled the Polish in the language picker. You can enroll into testing track to get version of the app built from master using this link https://play.google.com/apps/testing/cz.frantisekmasa.dnd to test it.

cc @oswida

@fmasa fmasa added this to the 3.21 milestone Dec 31, 2024
@fmasa
Copy link
Owner

fmasa commented Dec 31, 2024

If you are satisfied with the translation, this can be released with other changes in 3.21

@strusik01
Copy link
Contributor Author

strusik01 commented Dec 31, 2024 •
edited
Loading

That's great to hear :D

I've installed the dev-207278c, but it has no option for Polish yet. Is this the build you've just enrolled, or is it not live yet?
Can't wait to playtest it :D

@fmasa
Copy link
Owner

fmasa commented Dec 31, 2024

It's available in dev-0eeccd4 which I see as the latest in the Google Play. It should be available as update in few hours (at latest). The 207278c is quite old 🙂

Let me know if it does not appear for you 🙂

@strusik01
Copy link
Contributor Author

It just appeared, with Polish setting available.

Although something went wrong, changing the language in settings doesn't change it in app at all now.
Its the same for all languages, its English only

@fmasa
Copy link
Owner

fmasa commented Dec 31, 2024

That is odd, it works for me.

Is it possible that you are accidentally changing the Party language rather than app language?
If not, can you try restarting the app after the language change?

@strusik01
Copy link
Contributor Author

Solved the issue by reinstalling the app, I guess my installation broke. It works now ^^

I'll begin translating the Compendium now and playtest it for a few days, I'll let you know if something goes wrong.
Thank you very much and Happy New Year ;D

@fmasa
Copy link
Owner

fmasa commented Dec 31, 2024

Glad it works now (though it's still odd 🙂).
If you could test the Talent/Trait translation as well, that would be great! (See Effects for that).

Happy New Year to you too 🙂

@strusik01
Copy link
Contributor Author

strusik01 commented Dec 31, 2024 •
edited
Loading

I've found some issues, I can create bugs if you wish, but I'll specify them here for now:

  1. Polish word for "Base" is cut (it should be "Początkowa", seems too long)
    Location: Character creation -> Attributes
    Possible solution: Smaller font OR changing translation to "początk." so it would fit
    Screenshot:
    1 -Creating Character - Characteristics

  2. Polish words for "Basic Info" and "Point Pools" tabs overlap (too long)
    Location: Character creation -> Attributes
    Possible solution: Wrapping text for "Basic Info" (alias "Informacje Początkowe") tab
    Screenshot:
    2 - Creating Character - Tabs

  3. Polish words for "Fate" and "Resolve" wrapped in a weird way ;)
    Location: Character sheet -> Attributes tab
    Possible solution: Not sure for this one. Smaller font maybe, but it could be way too small for other languages. Maybe spreading the point pools to the sides would make enough space?
    Screenshot:
    3 - Character Sheet - Points

  4. Journal references links for Symptoms, Weapon/Armour/Item qualities, flaws and groups remain english.
    Links look for base english parent folders, though I saw them translated on Weblate. Its less of an issue for Symptoms, as I can still name them in polish, but polish qualities flaws and groups look for english names in Journal.
    Location: Disease or Weapon/Armour/Item trapping with added qualities/flaws/group
    Screenshots:
    4 - Journal Translation on Weblate
    4 - Weapon Armour Item - Qualities Flaws Groups reference linking
    4 - Weapon Group reference link
    4 - Diseases - Symptom linking

@fmasa
Copy link
Owner

fmasa commented Dec 31, 2024 via email

@strusik01
Copy link
Contributor Author

strusik01 commented Dec 31, 2024 •
edited
Loading

I made shorts for words too long, but what about Journal? Links try to find English journal entries, despite being translated to polish in Weblate. Is there a way to change parent folders for polish version?

@fmasa
Copy link
Owner

fmasa commented Jan 3, 2025

@strusik01 I'll take a look 🤔 There is likely a bug.

@strusik01
Copy link
Contributor Author

I've checked Talents/Traits, unfortunately they're not calculated at all if translated.
For example Savvy, if translated to Błyskotliwość, doesn't add up to Character's Intelligence.
As for Size trait it's the same, its not recognized if translated to Rozmiar, various sizes like Monstrous/Monstrualny probably aren't too.

@fmasa
Copy link
Owner

fmasa commented Jan 6, 2025

@strusik01 I'll take a look. I quickly tested German translation and it works correctly, so there is likely a problem with configuration of specific locales.

@fmasa fmasa mentioned this issue Jan 6, 2025
Merged
@fmasa fmasa closed this as completed in #396 Jan 6, 2025
@fmasa fmasa reopened this Jan 6, 2025
@fmasa
Copy link
Owner

fmasa commented Jan 6, 2025

@strusik01 fixed 🙂

(I closed the issue by accident 🙂)

@strusik01
Copy link
Contributor Author

It's mostly fixed, talents and traits work correctly.

As of the Journal, while Consumer's Guide and Conditions have translated and working well parent folders and links, the Disease and Infection ones don't work. Error message still states that its not translated, although now it does not work for neither English or Polish path (if language set to Polish).

@fmasa
Copy link
Owner

fmasa commented Jan 7, 2025

@strusik01 Good catch! The click through works, but the toast message used untranslated string. Fixed in #398

@strusik01
Copy link
Contributor Author

All good now, everything I've checked works. Polish is ready for release, thank you very much 😄

@fmasa fmasa closed this as completed Jan 8, 2025
@fmasa
Copy link
Owner

fmasa commented Jan 8, 2025

Great! I tagged 3.21.0 just now 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
3.21
Development

Successfully merging a pull request may close this issue.

Fix party language translations for Spanish, Russian and Polish fmasa/wfrp-master
2 participants
@fmasa @strusik01