#minor Adding Dynamic Workflows support for SdkTestingExecutor #318
+237
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request! 🙌 |
Addding a javadoc to SdkTestingExecutor Signed-off-by: Rodolfo Carvalho <rodolfo.ueg@gmail.com>
rscarvalho
force-pushed
the
rscarvalho/add-dynamic-workflow-testing-support
branch
from
4e5f640 to
054e2ce
Compare
honnix
reviewed
May 6, 2025
| } | ||
|
|
||
| @Test | ||
| public void testDelegatingWorkflow_OddA() { |
There was a problem hiding this comment.
nit: I think we can keep either OddA or OddB as they are doing the same thing and there isn't much need to have exhaustive tests for of(aConcreteValue % 2 == 0 && bConcreteValue % 2 == 0)) in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Adds support for testing
SdkDynamicWorkflowTask(dynamic workflows) usingSdkTestingExecutor, enabling assertions on their generated DAGs similarly to regular workflows.Type
Are all requirements met?
Complete description
This PR extends
SdkTestingExecutorto support dynamic workflows (SdkDynamicWorkflowTask) by wrapping them into a lightweight delegating workflow internally. This allows developers to test the structure and outputs of dynamic workflows using the same mechanisms used to test regular workflows, improving consistency and coverage in unit testing Flyte tasks.There were no existing issues or tracking requests for this feature — it was implemented to fill a current gap in testing capabilities for dynamic workflows in
flytekit-testing.Tracking Issue
NA
Follow-up issue
NA