Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Change llvm-12 to llvm-17 #81

Merged
merged 4 commits into from
Feb 18, 2025
Merged

Conversation

JSUYA
Copy link
Member

@JSUYA JSUYA commented Feb 13, 2025

ubuntu-latest has been changed to 24.04.
clang-12 is no longer in 24.04 repository.

@JSUYA
Copy link
Member Author

JSUYA commented Feb 13, 2025

note. #26

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build instructions in our README could be updated as well.

Please also check the recent changes in the upstream buildroot (I created this repo 3 years ago) to see if the build can be further optimized (or more restrictions applied) for clang-17. Here are the examples.

if (clang_version >= 11) {
cflags += [ "-Wno-psabi" ]
}
if (clang_version >= 14) {
cflags += [
"-Wno-unused-but-set-parameter",
"-Wno-unused-but-set-variable",
"-Wno-non-c-typedef-for-linkage",
]
}
if (clang_version >= 15) {
cflags += [ "-Wno-unqualified-std-cast-call" ]
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated PR by referencing the commit history here.
https://github.com/flutter/buildroot/blob/master/build/config/compiler/BUILD.gn
If there's anything else I should check, please let me know.

@JSUYA JSUYA merged commit 2ac5f1c into flutter-tizen:master Feb 18, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants