Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding first barebone impl for varadhi consumer. #147

Merged
merged 20 commits into from
Dec 4, 2024

Conversation

gauravAshok
Copy link
Collaborator

@gauravAshok gauravAshok commented May 31, 2024

TODO:

  • back-pressure from CC
  • error handling
  • tests
  • micro-bench

Future PR:

  • optional rate-limiter on RQ/DLQ produce.

@gauravAshok gauravAshok marked this pull request as draft May 31, 2024 04:42
@gauravAshok gauravAshok marked this pull request as ready for review November 29, 2024 09:03
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 17.13900% with 614 lines in your changes missing coverage. Please review.

Project coverage is 64.62%. Comparing base (78be60c) to head (5334c2d).
Report is 36 commits behind head on master.

Files with missing lines Patch % Lines
...art/varadhi/consumer/impl/VaradhiConsumerImpl.java 0.00% 114 Missing ⚠️
...com/flipkart/varadhi/consumer/DelayedConsumer.java 0.00% 83 Missing ⚠️
.../flipkart/varadhi/consumer/MessageSrcSelector.java 0.00% 57 Missing ⚠️
...rt/varadhi/consumer/processing/ProcessingLoop.java 0.00% 52 Missing ⚠️
...dhi/consumer/processing/GroupedProcessingLoop.java 0.00% 51 Missing ⚠️
...i/consumer/processing/UngroupedProcessingLoop.java 0.00% 36 Missing ⚠️
...rt/varadhi/entities/cluster/SubscriptionState.java 10.25% 28 Missing and 7 partials ⚠️
...rt/varadhi/consumer/impl/ConsumersManagerImpl.java 22.50% 31 Missing ⚠️
...m/flipkart/varadhi/entities/InternalQueueType.java 10.71% 25 Missing ⚠️
.../flipkart/varadhi/consumer/concurrent/Context.java 27.27% 14 Missing and 2 partials ⚠️
... and 32 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #147      +/-   ##
============================================
+ Coverage     63.11%   64.62%   +1.50%     
- Complexity      543     1120     +577     
============================================
  Files           133      211      +78     
  Lines          2790     5702    +2912     
  Branches        168      376     +208     
============================================
+ Hits           1761     3685    +1924     
- Misses          964     1860     +896     
- Partials         65      157      +92     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gauravAshok gauravAshok merged commit c314eb7 into flipkart-incubator:master Dec 4, 2024
2 checks passed
@gauravAshok gauravAshok deleted the consumer-e2e branch December 4, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add Core consumer impl; capable of processing messages from a consumer client.
3 participants