[1.8.9] Accessibility: aria-posinset index starts illegally at zero on discussion list feed #4143
Labels
type/accessibility
Issues relating to accessibility (keyboard navigation, screenreaders, text contrast, etc.)
Milestone
Current Behavior
Pull #3359 added useful aria Feed markup to discussion lists. The calculation that works out which number each item in the feed starts at has a small bug. The article count begins at zero instead of 1:
aria-posinset={pageNum * pageSize + itemNum}
Steps to Reproduce
You can see this in action by inspecting the HTML generated for the main discussion list at discuss.flarum.org:
Expected Behavior
Per the WAI-ARIA specification for this attribute,
aria-posinset
needs to start at 1:Screenshots
No response
Environment
Output of
php flarum info
No response
Possible Solution
No response
Additional Context
No response
The text was updated successfully, but these errors were encountered: