Skip to content

Commit

Permalink
remove useless logentry
Browse files Browse the repository at this point in the history
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
  • Loading branch information
Pavel Okhlopkov committed Nov 5, 2024
1 parent 31abc2d commit 67907e4
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions pkg/kube_events_manager/error_handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import (
type WatchErrorHandler struct {
description string
kind string
logEntry *log.Logger
metricStorage *metric_storage.MetricStorage

logger *log.Logger
Expand All @@ -24,9 +23,9 @@ func newWatchErrorHandler(description string, kind string, logLabels map[string]
return &WatchErrorHandler{
description: description,
kind: kind,
logEntry: utils.EnrichLoggerWithLabels(logger, logLabels),
metricStorage: metricStorage,
logger: logger,

logger: utils.EnrichLoggerWithLabels(logger, logLabels),
}
}

Expand All @@ -39,16 +38,16 @@ func (weh *WatchErrorHandler) handler(_ *cache.Reflector, err error) {
// Don't set LastSyncResourceVersionUnavailable - LIST call with ResourceVersion=RV already
// has a semantic that it returns data at least as fresh as provided RV.
// So first try to LIST with setting RV to resource version of last observed object.
weh.logEntry.Errorf("%s: Watch of %v closed with: %v", weh.description, weh.kind, err)
weh.logger.Errorf("%s: Watch of %v closed with: %v", weh.description, weh.kind, err)
errorType = "expired"
case err == io.EOF:
// watch closed normally
errorType = "eof"
case err == io.ErrUnexpectedEOF:
weh.logEntry.Errorf("%s: Watch for %v closed with unexpected EOF: %v", weh.description, weh.kind, err)
weh.logger.Errorf("%s: Watch for %v closed with unexpected EOF: %v", weh.description, weh.kind, err)
errorType = "unexpected-eof"
case err != nil:
weh.logEntry.Errorf("%s: Failed to watch %v: %v", weh.description, weh.kind, err)
weh.logger.Errorf("%s: Failed to watch %v: %v", weh.description, weh.kind, err)
errorType = "fail"
}

Expand Down

0 comments on commit 67907e4

Please sign in to comment.