fix: latency calculation in check #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashmehrotra
force-pushed
the
fix-latency-check
branch
from
e2c5514 to
122523e
Compare
yashmehrotra
force-pushed
the
fix-latency-check
branch
from
122523e to
8f03c56
Compare
moshloop
reviewed
Feb 3, 2025
| @@ -189,15 +190,17 @@ ORDER BY time | |||
| } | |||
| uptime.Failed += datapoint.Failed | |||
| uptime.Passed += datapoint.Passed | |||
| latencies.Append(float64(datapoint.Duration)) | |||
| latencies = append(latencies, float64(datapoint.Duration)) | |||
There was a problem hiding this comment.
Latencies will grow for as long canary-checker ius running:
This is what claude produced for a circular buffer, that segements latencies into buckets and then drops buckets after they expire: https://gist.github.com/moshloop/45308b7f3b48bd1a1a9b7ef0a54e4056
Although I suspect this will cause a significant amount of CPU in environments with hundreds to thousands of canaries.
The reason we originally chose the rolling implementation is that it is very fast, and approximately right.
There was a problem hiding this comment.
This is just for the graph api call, not the CRD status latencies. For this, we query check_statuses duration and then take the percentlie latency from that set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: flanksource/canary-checker#1986