make pkg/grammar free from any mission-control dependencies
#1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityathebe
force-pushed
the
chore/refactor-grammar-types
branch
from
eb38138 to
03af041
Compare
* feat: support grammar in resource selector .Matches * feat: implement grammar in resource selector .Matches() * properties lookup support for other operators * chore: use generic fields matcher for all models * fix: handle query field OR operator
adityathebe
force-pushed
the
chore/refactor-grammar-types
branch
from
1b7eea9 to
5e33a6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resourceSelector.Matches()needs to usegrammar.Parsebut that creates an import cycle betweentypesandgrammarpackages.