Including changes from Cloud RT Device #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored `EpsonRTPrinterSCU` to improve design and maintainability: - Reordered and updated `using` directives. - Replaced `HttpClient` with `IEpsonFpMateClient` interface. - Updated constructor to accept `IEpsonFpMateClient`. - Removed `_serialnr` field, using local variables instead. - Refactored methods to use `IEpsonFpMateClient` and new response models. - Added `SetReceiptResponse` method for handling printer responses. - Removed `FiscalReceiptResponse` class, integrated functionality. - Added `IEpsonFpMateClient` interface and `LocalEpsonFpMateClient` implementation. - Updated `SoapSerializer` for additional XML element replacements. These changes enhance modularity, testability, and code clarity.
Refactored ReceiptResponseHelper and EpsonRTPrinterSCU to reduce code duplication by introducing new helper methods for setting receipt response errors and adding warning signature items. Simplified EpsonRTPrinterSCU by removing redundant methods and delegating tasks to EpsonCommandFactory. Added new methods in EpsonCommandFactory for handling charge items, unspecified protocol receipts, and generating XML commands. Moved EpsonPrinterDepartmentConfiguration to its own file for better organization.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #387 #386