Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of PHP 8.3 #221

Closed
wilfriedwolf opened this issue May 30, 2024 · 2 comments · Fixed by #222
Closed

Support of PHP 8.3 #221

wilfriedwolf opened this issue May 30, 2024 · 2 comments · Fixed by #222

Comments

@wilfriedwolf
Copy link

Are there Plans to support PHP 8.3, is there more to it than altering composer.json?

General

  • Module version: 1.2.1
  • Magento version: 2.4.7
  • PHP version: 8.3.6

Issue description

Trying to update magento shop with PHP 8.3 results in:


Loading composer repositories with package information
Updating dependencies                                 
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - firegento/magesetup2 v1.2.0 requires php ~7.3.0||~7.4.0||~8.1.0 -> your php version (8.3.6) does not satisfy that requirement.
    - firegento/magesetup2 v1.2.1 requires php ~7.3.0||~7.4.0||~8.1.0||~8.2.0 -> your php version (8.3.6) does not satisfy that requirement.
    - Root composer.json requires firegento/magesetup2 ^1.2 -> satisfiable by firegento/magesetup2[v1.2.0, v1.2.1].

Steps to reproduce

  1. Install Magento 2.4.7 with firegento/magesetup2 and PHP 8.2
  2. Try to upgrade using composer update with PHP 8.3
@sprankhub
Copy link
Member

Most probably, it is enough to update composer.json. Could you test this and send a PR? That would be great.

@jg-development
Copy link

added pull request

@sprankhub sprankhub linked a pull request Aug 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants