New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new API for data validation #1647

Merged

ssbushi merged 5 commits into main from sb/validateDataset

Jan 27, 2025

Contributor

ssbushi commented Jan 22, 2025 •

edited

Loading

Part of #1554

This change provides the required API. The Dev UI can use this API to add validation callouts.

Checklist (if applicable):

PR title is following https://www.conventionalcommits.org/en/v1.0.0/
Tested (manually)


          new api for data validation

d9d16bf

ssbushi requested review from pavelgj, shrutip90 and MichaelDoyle

January 22, 2025 21:41

ssbushi changed the title ~~feat: add new api for data validation~~ feat: add new API for data validation

pavelgj reviewed

View reviewed changes

genkit-tools/common/src/eval/validate.ts Outdated Show resolved Hide resolved

pavelgj reviewed

View reviewed changes

genkit-tools/common/src/server/router.ts Outdated Show resolved Hide resolved

pavelgj reviewed

View reviewed changes

genkit-tools/common/src/server/router.ts Outdated Show resolved Hide resolved

pavelgj reviewed

View reviewed changes

genkit-tools/common/src/eval/validate.ts Show resolved Hide resolved

pavelgj reviewed

View reviewed changes

genkit-tools/common/src/server/router.ts Outdated Show resolved Hide resolved

pavelgj reviewed

View reviewed changes

genkit-tools/common/src/server/router.ts Outdated Show resolved Hide resolved

pavelgj reviewed

View reviewed changes

genkit-tools/common/src/eval/validate.ts Outdated Show resolved Hide resolved

pavelgj reviewed

View reviewed changes

genkit-tools/common/src/types/apis.ts Outdated Show resolved Hide resolved

ssbushi added 2 commits

January 27, 2025 15:56


          feedback

b4cf32d


          int to string

ssbushi requested a review from pavelgj

January 27, 2025 16:09

pavelgj reviewed

View reviewed changes

genkit-tools/common/src/types/apis.ts Outdated Show resolved Hide resolved

pavelgj approved these changes

View reviewed changes

ssbushi added 2 commits

January 27, 2025 21:28


          stronger types

431713c


          better typing

2e4a9ea

ssbushi merged commit 8e553dc into main

4 checks passed

ssbushi deleted the sb/validateDataset branch

January 27, 2025 21:38

ssbushi mentioned this pull request

[Dev UI] Available datasets should be scoped to the target being tested #1554

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet