-
Notifications
You must be signed in to change notification settings - Fork 7
feat: Auto-fetch "last updated" from Git history #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for fipguide ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
In my personal opinion this is a pretty neat feature. However I think we should discuss this topic. However I don't know if we would always like to display the authors name? Mayber we should show the name, when hovering over the infos, as well as a link to the last commit/change of this page using the .Hash variable to build a URL. |
I can move the name to the tooltip, that's no issue and probably makes sense. And a link should be fine too, but not sure where to place it. |
The author's information is also relevant for Google, so we should decide it. See #70 (comment). Unfortunately, the tooltip feature is currently not available via screen reader – could you please adjust this? |
ac6a279
to
5a237e3
Compare
|
I just removed the "date" metadata from the wiki |
5a237e3
to
327cb38
Compare
The proposed changes are implemented now. |
It's not longer needed to provide the "date" attribute in the page metadata. If it's not provided, the information will be auto-fetched from Git.
327cb38
to
b1ca760
Compare
The "Updated at" is now also pagefind-ignored and no longer shows up in the search :) |
Description
It's not longer needed to provide the "date" attribute in the page metadata. If it's not provided, the information will be auto-fetched from Git.
Related to #95
The disadvantage with the auto-updated date is that also minor changes like updated grammar, spelling etc. will also update the "last updated" field.