Skip to content

feat: Auto-fetch "last updated" from Git history #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025
Merged

Conversation

MoritzWeber0
Copy link
Member

Description

It's not longer needed to provide the "date" attribute in the page metadata. If it's not provided, the information will be auto-fetched from Git.
Related to #95

The disadvantage with the auto-updated date is that also minor changes like updated grammar, spelling etc. will also update the "last updated" field.

Copy link

netlify bot commented May 3, 2025

Deploy Preview for fipguide ready!

Name Link
🔨 Latest commit b1ca760
🔍 Latest deploy log https://app.netlify.com/sites/fipguide/deploys/681bd3021511600008df7f1a
😎 Deploy Preview https://deploy-preview-98--fipguide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MoritzWeber0 MoritzWeber0 added the technical Technical issues, e.g. related to Hugo, HTML, CSS, deployment, etc. label May 3, 2025
@lenderom
Copy link
Member

lenderom commented May 3, 2025

In my personal opinion this is a pretty neat feature. However I think we should discuss this topic.
I think it's pretty good for not forgetting to update the date.

However I don't know if we would always like to display the authors name? Mayber we should show the name, when hovering over the infos, as well as a link to the last commit/change of this page using the .Hash variable to build a URL.

@MoritzWeber0
Copy link
Member Author

In my personal opinion this is a pretty neat feature. However I think we should discuss this topic. I think it's pretty good for not forgetting to update the date.

However I don't know if we would always like to display the authors name? Mayber we should show the name, when hovering over the infos, as well as a link to the last commit/change of this page using the .Hash variable to build a URL.

I can move the name to the tooltip, that's no issue and probably makes sense. And a link should be fine too, but not sure where to place it.

@therobrob
Copy link
Member

The author's information is also relevant for Google, so we should decide it. See #70 (comment).

Unfortunately, the tooltip feature is currently not available via screen reader – could you please adjust this?

@MoritzWeber0
Copy link
Member Author

Unfortunately, the tooltip feature is currently not available via screen reader – could you please adjust this?

Made it keyboard usable and should be recognized now. Let me know if there is anything else to improve from accessibility perspective :)
image

@lenderom
Copy link
Member

lenderom commented May 5, 2025

  • accessible
  • link to file history in github
  • no hover
  • no name only date

@lenderom
Copy link
Member

lenderom commented May 7, 2025

I just removed the "date" metadata from the wiki

@MoritzWeber0
Copy link
Member Author

  • accessible

    • link to file history in github

    • no hover

    • no name only date

The proposed changes are implemented now.

@MoritzWeber0 MoritzWeber0 requested a review from lenderom May 7, 2025 20:46
It's not longer needed to provide the "date" attribute in the
page metadata. If it's not provided, the information will be
auto-fetched from Git.
@MoritzWeber0
Copy link
Member Author

The "Updated at" is now also pagefind-ignored and no longer shows up in the search :)

@lenderom lenderom merged commit 130b604 into main May 8, 2025
7 checks passed
@lenderom lenderom deleted the enable-git-info branch May 8, 2025 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical Technical issues, e.g. related to Hugo, HTML, CSS, deployment, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants