Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gas error when deploying contract from Safe multisig #93

Open
xBalbinus opened this issue Jan 9, 2025 · 3 comments
Open

Gas error when deploying contract from Safe multisig #93

xBalbinus opened this issue Jan 9, 2025 · 3 comments
Assignees
Labels
from slack Painpoint request flagged from Slack

Comments

@xBalbinus
Copy link
Collaborator

xBalbinus commented Jan 9, 2025

Issue:

GS013 error faced when deploying contract from Safe multisig. require(success || safeTxGas != 0 || gasPrice != 0, "GS013")

Impact:

While this issue is being triaged, if it's related to setting the right safeTxGas (gas limit) to complete the transaction, it raises issue to the inaccuracy of gas estimation API on Filecoin, related to #89 and the burning of any gas estimates >10% on Filecoin, where it usually is fully refunded on other chains. This could lead to a negative builder experience and push them to use other L2s. This is feedback from existing 3rd party integrations through 2024.

Proposed solution:

  1. Triaging a fix for deployment from multisig, whether it's a config issue, a Filecoin gas blocker or if we need an additional library from Safe, to be added to FVM
  2. For gas estimation, this is being discussed in Gas estimation API is inconsistent #89

Description:
Hey @eva

Has anyone had success deploying a new smart contract using SAFE yet on FEVM ? Looks like sending funds/interacting with an existing contract is fine but deploying a new one is not clear. I am using the transaction builder here with the data set to the contract byte code but the transactions always fails even after both signers have signed (2/2 SAFE multisig).

Is there a recommended flow to deploy new contracts ?

Source:
https://filecoinproject.slack.com/archives/C0745JU645A/p1736416313584709?thread_ts=1736416313.584709&cid=C0745JU645A

@xBalbinus xBalbinus added the from slack Painpoint request flagged from Slack label Jan 9, 2025
@github-project-automation github-project-automation bot moved this to 🌑 Unstarted / Needs Triage in Filecoin DX Painpoints Tracker Jan 9, 2025
@trruckerfling trruckerfling changed the title <New Issue From Slack> Gas error when deploying contract from Safe multisig Jan 9, 2025
@trruckerfling trruckerfling self-assigned this Jan 9, 2025
@xBalbinus
Copy link
Collaborator Author

Standard for this is to create a contract then transfer ownership to Safe account, then have safe account call functions on the smart contract.

@xBalbinus
Copy link
Collaborator Author

Otherwise, the contract for creating these contracts has been deployed already

@xBalbinus xBalbinus moved this from 🌑 Unstarted / Needs Triage to 🚧 In progress in Filecoin DX Painpoints Tracker Jan 10, 2025
@trruckerfling
Copy link
Collaborator

@xBalbinus to test code snippet from shashank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from slack Painpoint request flagged from Slack
Projects
Status: 🚧 In progress
Development

No branches or pull requests

2 participants