Skip to content

Commit

Permalink
Update PULL_REQUEST_TEMPLATE.md
Browse files Browse the repository at this point in the history
  • Loading branch information
koh-gt authored Nov 27, 2023
1 parent 1d6dde7 commit 13c2efa
Showing 1 changed file with 13 additions and 23 deletions.
36 changes: 13 additions & 23 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,18 +1,13 @@
<!--
*** Please remove the following help text before submitting: ***
Thank you for contributing to Ferrite Core.
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
immediately. Code comments are recommended and encouraged.
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
Please provide a brief explanation of how
Ferrite Core user or developer experience is improved:
* Any test improvements or new tests that improve coverage are always welcome.
* All other changes should have accompanying unit tests (see `src/test/`) or
Expand All @@ -23,21 +18,16 @@ significantly:
explanation of the potential issue as well as reasoning for the way the bug
was fixed.
* Features are welcome, but might be rejected due to design or scope issues.
If a feature is based on a lot of dependencies, contributors should first
consider building the system outside of Bitcoin Core, if possible.
* Refactoring changes are only accepted if they are required for a feature or
bug fix or otherwise improve developer experience significantly. For example,
most "code style" refactoring changes require a thorough explanation why they
are useful, what downsides they have and why they *significantly* improve
developer experience or avoid serious programming bugs. Note that code style
is often a subjective matter. Unless they are explicitly mentioned to be
preferred in the [developer notes](/doc/developer-notes.md), stylistic code
changes are usually rejected.
Contributors should first consider building the system outside of Ferrite Core, if possible.
* Note that code style is often a subjective matter.
Unless explicitly mentioned in the [developer notes](/doc/developer-notes.md),
stylistic code changes are usually rejected.
-->

<!--
Bitcoin Core has a thorough review process and even the most trivial change
needs to pass a lot of eyes and requires non-zero or even substantial time
effort to review. There is a huge lack of active reviewers on the project, so
patches often sit for a long time.
Ferrite Core has a thorough review process and changes
need time and effort to review.
There is a huge lack of active reviewers on the project,
so patches may sit for a long time until the next release.
Thank you for your patience.
-->

0 comments on commit 13c2efa

Please sign in to comment.