Deflake windows tests (#39)

* Deflaking the windows tests

Author: fergusstrange

.github/workflows/build.yml

@@ -83,4 +83,4 @@ jobs:
       - name: Platform Tests
         run: |
           cd platform-test
-          go test -v ./...
+          go test -v -race ./...

platform-test/platform_test.go

@@ -4,9 +4,7 @@ import (
 	"database/sql"
 	"fmt"
 	"io/ioutil"
-	"os"
 	"path/filepath"
-	"strconv"
 	"strings"
 	"testing"
 
@@ -21,15 +19,19 @@ func Test_AllMajorVersions(t *testing.T) {
 		embeddedpostgres.V10,
 		embeddedpostgres.V9,
 	}
-	tempExtractLocation, err := ioutil.TempDir("", "embedded_postgres_go_tests")
+
+	tempExtractLocation, err := ioutil.TempDir("", "embedded_postgres_tests")
 	if err != nil {
 		t.Fatal(err)
 	}
 
-	for testNumber, version := range allVersions {
+	for i, v := range allVersions {
+		testNumber := i
+		version := v
 		t.Run(fmt.Sprintf("MajorVersion_%s", version), func(t *testing.T) {
 			port := uint32(5555 + testNumber)
-			runtimePath := filepath.Join(tempExtractLocation, strconv.Itoa(testNumber))
+			runtimePath := filepath.Join(tempExtractLocation, string(version))
+
 			database := embeddedpostgres.NewDatabase(embeddedpostgres.DefaultConfig().
 				Version(version).
 				Port(port).
@@ -65,15 +67,13 @@ func Test_AllMajorVersions(t *testing.T) {
 			}
 		})
 	}
-	if err := os.RemoveAll(tempExtractLocation); err != nil {
-		t.Fatal(err)
-	}
 }
 
 func shutdownDBAndFail(t *testing.T, err error, db *embeddedpostgres.EmbeddedPostgres, version embeddedpostgres.PostgresVersion) {
 	if err := db.Stop(); err != nil {
 		t.Fatalf("Failed for version %s with error %s", version, err)
 	}
+
 	t.Fatalf("Failed for version %s with error %s", version, err)
 }