Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] pathlib issue windows with older onnxruntime versions #62

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

felixdittrich92
Copy link
Owner

This PR:

  • transform to string if pathlib Path object which raises issues on windows with older onnxruntime versions

@felixdittrich92 felixdittrich92 added the type: bug Something isn't working label Jan 15, 2025
@felixdittrich92 felixdittrich92 self-assigned this Jan 15, 2025
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.22%. Comparing base (e08ff57) to head (b50d0e4).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #62   +/-   ##
=======================================
  Coverage   98.22%   98.22%           
=======================================
  Files          66       66           
  Lines        2030     2031    +1     
=======================================
+ Hits         1994     1995    +1     
  Misses         36       36           
Flag Coverage Δ
unittests 98.22% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felixdittrich92 felixdittrich92 merged commit 14d7b03 into main Jan 15, 2025
24 checks passed
@felixdittrich92 felixdittrich92 deleted the path-fix branch January 15, 2025 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants