New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lyric): support to parse ill-formed lyric like [mm:ss:ms] #864

Merged

cosven merged 1 commit into feeluown:master from waylyrics:fix-lrc-parse

Sep 10, 2024

Contributor

mokurin000 commented Aug 12, 2024 •

edited

Loading

close #863


          fix(lyric): support to parse ill-formed lyric like [mm:ss:ms]

9d9ea7c

coveralls commented Aug 12, 2024

Pull Request Test Coverage Report for Build 10345277962

Details

4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 55.103%

Totals
Change from base Build 10269575213:	0.03%
Covered Lines:	9886
Relevant Lines:	17941

💛 - Coveralls

cosven merged commit 9aff59b into feeluown:master

9 checks passed

Member

cosven commented Sep 10, 2024

mokurin000 deleted the fix-lrc-parse branch

September 10, 2024 12:54

Contributor Author

mokurin000 commented Sep 10, 2024 •

edited

Loading

Original LRC support neither hh: part nor ss:xx variant. Because the later is far more common, we will choose it rather than hh: field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet