Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

player: add timeout when fetching song metadata #853

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

cosven
Copy link
Member

@cosven cosven commented Jul 7, 2024

Currently, the player play the media after metadata is fetched.
However, some provider (ytmusic) cost much time in fetching metadata.
So add a timeout to workaround this problem.

@coveralls
Copy link

coveralls commented Jul 7, 2024

Pull Request Test Coverage Report for Build 9827709781

Details

  • 8 of 13 (61.54%) changed or added relevant lines in 3 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 55.062%

Changes Missing Coverage Covered Lines Changed/Added Lines %
feeluown/library/library.py 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
feeluown/library/library.py 5 66.15%
Totals Coverage Status
Change from base Build 9732123954: -0.04%
Covered Lines: 9849
Relevant Lines: 17887

💛 - Coveralls

@cosven cosven merged commit 8921ae2 into feeluown:master Jul 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants