Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

library: use yt-dlp as a global standby-provider #842

Merged
merged 5 commits into from
Jun 30, 2024
Merged

Conversation

cosven
Copy link
Member

@cosven cosven commented Jun 24, 2024

To use this feature, you should

  1. instance yt-dlp pip install yt-dlp
  2. setup config in ~/.fuorc, for example
config.YTDL_RULES = [{'name': 'match_source',
                      'pattern': 'ytmusic',
                      'http_proxy': 'http://127.0.0.1:7890'},]

@coveralls
Copy link

coveralls commented Jun 24, 2024

Pull Request Test Coverage Report for Build 9650720480

Details

  • 25 of 61 (40.98%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 55.166%

Changes Missing Coverage Covered Lines Changed/Added Lines %
feeluown/app/app.py 4 6 66.67%
feeluown/library/library.py 8 19 42.11%
feeluown/library/ytdl.py 11 34 32.35%
Files with Coverage Reduction New Missed Lines %
feeluown/task.py 1 92.41%
Totals Coverage Status
Change from base Build 9367665860: -0.06%
Covered Lines: 9841
Relevant Lines: 17839

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 27, 2024

Pull Request Test Coverage Report for Build 9691076479

Details

  • 38 of 108 (35.19%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 55.103%

Changes Missing Coverage Covered Lines Changed/Added Lines %
feeluown/library/provider_protocol.py 3 4 75.0%
feeluown/app/app.py 4 6 66.67%
feeluown/library/library.py 15 32 46.88%
feeluown/library/ytdl.py 14 64 21.88%
Files with Coverage Reduction New Missed Lines %
feeluown/task.py 1 92.41%
Totals Coverage Status
Change from base Build 9367665860: -0.1%
Covered Lines: 9853
Relevant Lines: 17881

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 30, 2024

Pull Request Test Coverage Report for Build 9729470175

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 38 of 108 (35.19%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 55.103%

Changes Missing Coverage Covered Lines Changed/Added Lines %
feeluown/library/provider_protocol.py 3 4 75.0%
feeluown/app/app.py 4 6 66.67%
feeluown/library/library.py 15 32 46.88%
feeluown/library/ytdl.py 14 64 21.88%
Files with Coverage Reduction New Missed Lines %
feeluown/task.py 1 92.41%
Totals Coverage Status
Change from base Build 9367665860: -0.1%
Covered Lines: 9853
Relevant Lines: 17881

💛 - Coveralls

@cosven cosven merged commit 4d1f4aa into feeluown:master Jun 30, 2024
7 of 9 checks passed
@cosven cosven deleted the ytdl branch June 30, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants