Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Deprecate Helm Operator - docs #5022

Conversation

tmihalac
Copy link
Contributor

@tmihalac tmihalac commented Feb 6, 2025

Updated Helm Operator to point out that the operator is deprecated and the new feast go operator should be used instead.

What this PR does / why we need it:

The feast go operator is more powerful and allows a flexible deployment

@tmihalac tmihalac changed the title doc: Deprecate Helm Operator - docs docs: Deprecate Helm Operator - docs Feb 6, 2025
@tmihalac tmihalac marked this pull request as ready for review February 7, 2025 00:59
@tmihalac tmihalac requested a review from a team as a code owner February 7, 2025 00:59
@tmihalac
Copy link
Contributor Author

tmihalac commented Feb 7, 2025

Can you re-trigger test ? @franciscojavierarceo

@franciscojavierarceo
Copy link
Member

done! that was strange though that test is usually not flaky...

@lokeshrangineni
Copy link
Contributor

lokeshrangineni commented Feb 7, 2025

Also it is better to mention deprecated: true in the chart.yaml files of the helm charts which we are deprecating. on top of my head this is one of them - https://github.com/feast-dev/feast/blob/master/infra/charts/feast/Chart.yaml

@tchughesiv
Copy link
Contributor

tchughesiv commented Feb 7, 2025 via email

@lokeshrangineni lokeshrangineni enabled auto-merge (squash) February 7, 2025 17:51
auto-merge was automatically disabled February 7, 2025 19:50

Head branch was pushed to by a user without write access

@tmihalac
Copy link
Contributor Author

tmihalac commented Feb 7, 2025

OK reverted the chart deprecation tag

@tmihalac tmihalac force-pushed the deprecate-feast-helm-operator-in-docs branch 2 times, most recently from 8de4173 to b50e308 Compare February 7, 2025 19:55
@lokeshrangineni lokeshrangineni enabled auto-merge (squash) February 7, 2025 20:11
@tmihalac tmihalac requested a review from tchughesiv February 7, 2025 20:21
docs/getting-started/components/feature-server.md Outdated Show resolved Hide resolved
infra/charts/feast-feature-server/Chart.yaml Outdated Show resolved Hide resolved
Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
auto-merge was automatically disabled February 8, 2025 00:06

Head branch was pushed to by a user without write access

@tmihalac tmihalac force-pushed the deprecate-feast-helm-operator-in-docs branch from b50e308 to 778afbc Compare February 8, 2025 00:06
@tmihalac
Copy link
Contributor Author

tmihalac commented Feb 8, 2025

Now it should be ok

Copy link
Contributor

@tchughesiv tchughesiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@franciscojavierarceo franciscojavierarceo merged commit b24d531 into feast-dev:master Feb 10, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants