Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable simplex meshes #132

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Enable simplex meshes #132

merged 1 commit into from
Sep 20, 2024

Conversation

fdrmrc
Copy link
Owner

@fdrmrc fdrmrc commented Sep 13, 2024

Working on #131. This PR allows solving problems stemming from simplex meshes. Before this PR, it was possible to perform agglomeration but several features (for instance interpolation ) were not yet implemented. Only 13ff100 is relevant. The set of changes is actually quite minimal.

FYI @luca-heltai @andreacangiani
Here's the output and related $p$-convergence (with $p=1,2,3$) for the classical sin-sin manufactured solution interpolated onto a fine, unstructured, simplicial mesh. The element type is $P_{-k}$, the classical scalar discontinuous Lagrange finite element. As of now, the maximum supported polynomial degree is $3$ (higher degrees are not yet available upstream in deal.II)

sol_on_simplex_mesh

image

@luca-heltai
Copy link
Collaborator

This is very good. I see that only small changes are required for the actual code to run on simplices. Very nice!

@fdrmrc fdrmrc force-pushed the enable_simplex_meshes branch 6 times, most recently from 03ebbf2 to cc2f880 Compare September 16, 2024 14:43
@fdrmrc fdrmrc added enhancement New feature or request Applications Related to applications/examples snippets grids Related to grids and mesh generation labels Sep 16, 2024
@fdrmrc
Copy link
Owner Author

fdrmrc commented Sep 16, 2024

The failing test will be fixed in #134

@fdrmrc fdrmrc force-pushed the enable_simplex_meshes branch from cc2f880 to 0e0558f Compare September 18, 2024 08:39
@fdrmrc fdrmrc marked this pull request as ready for review September 18, 2024 12:14
@fdrmrc
Copy link
Owner Author

fdrmrc commented Sep 18, 2024

Compilation fails because SmartPointer has been renamed ObserverPointer upstream.

@fdrmrc fdrmrc merged commit 9aa5396 into main Sep 20, 2024
1 of 3 checks passed
@luca-heltai luca-heltai deleted the enable_simplex_meshes branch November 21, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Applications Related to applications/examples snippets enhancement New feature or request grids Related to grids and mesh generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants