-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collaborating with django-renderpdf #69
Comments
@WhyNotHugo the link you provided to django-renderpdf doesn't work. 404. Is your project better maintained than this? |
My bad, correct link here: https://github.com/WhyNotHugo/django-renderpdf/ |
Thank you for reaching out @WhyNotHugo! In 2016 I also took over this code due to stagnant maintenance and am very much open to collaboration and/or merging of projects to keep it alive now. There should be one -- and preferably only one -- obvious way to do it. ;)
That sounds like a good plan and I am open to accept pull-requests in that direction and probably subsequently handing over maintenance/access to this project's github/pypi. |
Any news regarding this collaboration @WhyNotHugo? Almost one year later, which library would you recommend to implement HTML to PDF conversion in a new Django project? |
No new really, haven't had any time to look further into this. Both libraries have slightly different features, so check out which ones you need and pick based on that. Any other response that I can give is obviously biased. |
Hi! I maintain django-renderpdf, which I wrote back in 2017 to, well, render PDFs. It also uses weasyprint under the hood.
I've come across
django-weasyprint
a few times during the years. It seems that around 80% of what both projects do is the same. There's some duplicate effort going on between both projects. I'd like to contribute todjango-weasyprint
by merging any functionality that's missing, and then have a migration plan to transition projects fromdjango-renderpdf
intodjango-weasyprint
.I wanted to hear your thoughts on this and see if this sounds good to you too before actually doing anything.
From what I can tell, these are the biggest differences with
django-renderpdf
:django_url_fetcher
that tries to resolve static files. This avoids network round-trips to reload the same CSS and PNG files over the network over and over again. I do think that your approach using abase_url
is simpler for a lot of cases.get_template_names
uses the same convention as Django, to allow applications to override templates (django-afip relies on this to use a rather flexible template overriding mechanism in the same way as Django itself does for built-in views).
The text was updated successfully, but these errors were encountered: