Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collaborating with django-renderpdf #69

Open
WhyNotHugo opened this issue Apr 3, 2023 · 5 comments
Open

Collaborating with django-renderpdf #69

WhyNotHugo opened this issue Apr 3, 2023 · 5 comments
Assignees

Comments

@WhyNotHugo
Copy link

WhyNotHugo commented Apr 3, 2023

Hi! I maintain django-renderpdf, which I wrote back in 2017 to, well, render PDFs. It also uses weasyprint under the hood.

I've come across django-weasyprint a few times during the years. It seems that around 80% of what both projects do is the same. There's some duplicate effort going on between both projects. I'd like to contribute to django-weasyprint by merging any functionality that's missing, and then have a migration plan to transition projects from django-renderpdf into django-weasyprint.

I wanted to hear your thoughts on this and see if this sounds good to you too before actually doing anything.

From what I can tell, these are the biggest differences with django-renderpdf:

@bbrendon
Copy link

@WhyNotHugo the link you provided to django-renderpdf doesn't work. 404.

Is your project better maintained than this?

@WhyNotHugo
Copy link
Author

My bad, correct link here: https://github.com/WhyNotHugo/django-renderpdf/

@fdemmer
Copy link
Owner

fdemmer commented Aug 17, 2023

Thank you for reaching out @WhyNotHugo!

In 2016 I also took over this code due to stagnant maintenance and am very much open to collaboration and/or merging of projects to keep it alive now. There should be one -- and preferably only one -- obvious way to do it. ;)

I'd like to contribute to django-weasyprint by merging any functionality that's missing, and then have a migration plan to transition projects from django-renderpdf into django-weasyprint.

That sounds like a good plan and I am open to accept pull-requests in that direction and probably subsequently handing over maintenance/access to this project's github/pypi.

@scur-iolus
Copy link

Any news regarding this collaboration @WhyNotHugo? Almost one year later, which library would you recommend to implement HTML to PDF conversion in a new Django project?

@WhyNotHugo
Copy link
Author

No new really, haven't had any time to look further into this.

Both libraries have slightly different features, so check out which ones you need and pick based on that. Any other response that I can give is obviously biased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants