Attach prettifier to query #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prettification of terms is typically related to some particular query rather than a naked Universe, so add a convenience type for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prettification of terms is typically related to some particular query rather than a naked Universe, so add a convenience type for that.
I haven't tried prettification before, but now I discovered too many moving pieces. This tries to stick some of them together: a prettifier is most relevant when dealing with a Query, rather than just a Universe.
In fact, the handful of .pretty() calls in the code base were immediately referring to the query scope, so they are all improved now: the calls have not two (universe, scope) but only one moving piece (query).
I have a suspicion this also fixes some bugs I introduced at an earlier rework where I used the unmodified Universe to render the query terms.