Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support some and none label #16

Merged
merged 2 commits into from
Jan 30, 2025
Merged

feat: support some and none label #16

merged 2 commits into from
Jan 30, 2025

Conversation

tisonkun
Copy link
Contributor

This closes #11 .

@tisonkun
feat: support some and none label
c0db7c4 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun requested a review from andylokandy January 28, 2025 12:51
@tisonkun
Copy link
Contributor Author

@andylokandy May we release a 1.0.0 after this PR merged?

@tisonkun
test: add test for option label
298d2bb 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun mentioned this pull request Jan 28, 2025
Closed
@andylokandy andylokandy merged commit cb8f984 into main Jan 30, 2025
5 checks passed
@andylokandy andylokandy deleted the option branch January 30, 2025 06:48
@andylokandy
Copy link
Collaborator

Thank you!

@andylokandy
Copy link
Collaborator

andylokandy commented Jan 30, 2025 •
edited
Loading

May we release a 1.0.0 after this PR merged?

Do you think there is any improvement has to be made before 1.0?

@tisonkun
Copy link
Contributor Author

Do you think there is any improvement has to be made before 1.0?

Not yet.

Logcall is designed to automatically log function calls, their inputs, and their outputs. Our current state should solve it well.

I'm considering adding more options to manipulating log!'s param, or support other Try trait impl (or directly over the Try trait). However, these can be over generic at this point, and adding more support won't break compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andylokandy andylokandy andylokandy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Would be nice to have some and none like ok and err
2 participants
@tisonkun @andylokandy