First performance module POC for using vectors on cruise climb model #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues
======
- Added 2
Complexity increasing per file
==============================
- src/fastoad/models/performances/mission.py 1
Clones added
============
- src/fastoad/models/performances/breguet.py 1
- src/fastoad/models/performances/mission.py 1
See the complete overview on Codacy |
| @@ -0,0 +1,252 @@ | |||
| """ | |||
There was a problem hiding this comment.
| self.declare_partials("data:propulsion:altitude", "*", method="fd") | ||
| self.declare_partials("data:propulsion:mach", "*", method="fd") | ||
|
|
||
| def compute(self, inputs, outputs, discrete_inputs=None, discrete_outputs=None): |
There was a problem hiding this comment.
Codecov Report
@@ Coverage Diff @@
## master #180 +/- ##
==========================================
+ Coverage 91.32% 91.52% +0.19%
==========================================
Files 172 173 +1
Lines 6113 6254 +141
Branches 467 467
==========================================
+ Hits 5583 5724 +141
Misses 439 439
Partials 91 91
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR is a proof of concept for using vectors for trajectories in the performance module. This has been achieved only for the cruise segment of the mission:
The distance step is constant and determined with respect to the number of flight points and cruise distance, resulting in a variable time step.