Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: optimize broadcastEvent() with event mapping #2520

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NikolaiKryshnev
Copy link

@NikolaiKryshnev NikolaiKryshnev commented Feb 5, 2025

Why is this change needed?

This change improves the performance, readability, and maintainability of the broadcastEvent() method by replacing multiple if-else conditions with a structured mapping of event handlers.

Key improvements:
Performance: Eliminates unnecessary condition checks by returning early when an event match is found.
Readability: Uses a Map-like structure to store event handlers, making it clear which conditions trigger which events.
Maintainability: Adding new event types now requires only updating the event handlers list, instead of modifying multiple if-else conditions.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR refactors the broadcastEvent method in the storeEventHandler.ts file to improve its structure by using an array of event handlers instead of multiple if-else statements, enhancing readability and maintainability.

Detailed summary

  • Replaced multiple if-else statements with an array of tuples containing event handler functions and their corresponding event names.
  • Introduced a for loop to iterate through the event handlers, emitting the appropriate event if a handler matches.
  • Maintained the error handling for invalid event types.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Feb 5, 2025

⚠️ No Changeset found

Latest commit: 12cf919

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 6:56pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant