Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct logic in delete_username_proof_transaction to delete instead of re-adding #2519

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Himess
Copy link

@Himess Himess commented Feb 4, 2025

Why is this change needed?

The current implementation of the delete_username_proof_transaction function incorrectly re-adds the username proof after encoding it instead of deleting it. This PR corrects that logic by replacing the re-add operation with the proper deletion operation. It ensures that the function now correctly removes the username proof from the database when called, fixing the logic and ensuring the expected behavior.

Merge Checklist


PR-Codex overview

This PR focuses on modifying the handling of a primary key in the name_registry_events.rs file, specifically changing how data is stored in a transaction.

Detailed summary

  • Removed the line that puts the primary_key into the transaction (txn.put(primary_key.clone(), buf);).
  • Added a line that deletes the primary_key from the transaction (txn.delete(primary_key);).

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Feb 4, 2025

⚠️ No Changeset found

Latest commit: c74dceb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 6:15pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant