fix: Correct logic in delete_username_proof_transaction
to delete instead of re-adding
#2519
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this change needed?
The current implementation of the
delete_username_proof_transaction
function incorrectly re-adds the username proof after encoding it instead of deleting it. This PR corrects that logic by replacing the re-add operation with the proper deletion operation. It ensures that the function now correctly removes the username proof from the database when called, fixing the logic and ensuring the expected behavior.Merge Checklist
PR-Codex overview
This PR focuses on modifying the handling of a primary key in the
name_registry_events.rs
file, specifically changing how data is stored in a transaction.Detailed summary
primary_key
into the transaction (txn.put(primary_key.clone(), buf);
).primary_key
from the transaction (txn.delete(primary_key);
).