Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rename verifications message to support multiple protocols #1667

Merged
merged 4 commits into from
Feb 7, 2024

Conversation

sanjayprabhu
Copy link
Contributor

@sanjayprabhu sanjayprabhu commented Feb 6, 2024

Motivation

Bring back #1637 and add HTTP API backwards compatibility

Change Summary

Describe the changes being made in 1-2 concise sentences.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

Additional Context

If this is a relatively large or complex change, provide more details here that will help reviewers


PR-Codex overview

Detailed summary

  • Renamed some verification message fields to support more protocols.
  • Added bs58 package as a dependency in package.json.

The following files were skipped due to too many changes: apps/hubble/src/rpc/httpServer.ts, yarn.lock, packages/core/src/protobufs/typeguards.ts, apps/hubble/src/rpc/server.ts, packages/core/src/crypto/eip712.ts, packages/core/src/signers/testUtils.ts, packages/core/src/builders.ts, apps/hubble/src/storage/engine/index.ts, apps/hubble/src/rpc/test/verificationService.test.ts, apps/hubble/src/storage/db/migrations/4.uniqueVerifications.test.ts, apps/replicator/src/util.ts, protobufs/schemas/message.proto, apps/replicator/src/processors/verification.ts, apps/hubble/src/rpc/test/httpServer.test.ts, packages/core/src/builders.test.ts, packages/core/src/validations.ts, apps/hubble/src/storage/engine/index.test.ts, packages/core/src/factories.ts, packages/core/src/validations.test.ts, apps/hubble/src/storage/stores/verificationStore.test.ts, apps/hubble/src/storage/stores/verificationStore.ts, packages/hub-web/src/generated/message.ts, packages/hub-nodejs/src/generated/message.ts, packages/core/src/protobufs/generated/message.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@sanjayprabhu sanjayprabhu added the t-feat Add a new feature or protocol improvement label Feb 6, 2024
Copy link

changeset-bot bot commented Feb 6, 2024

🦋 Changeset detected

Latest commit: ec6442b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@farcaster/hub-nodejs Patch
@farcaster/hub-web Patch
@farcaster/replicator Patch
@farcaster/core Patch
@farcaster/hubble Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2024 0:51am

Copy link

socket-security bot commented Feb 6, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/base-x@4.0.0 None 0 9.44 kB junderw
npm/bs58@5.0.0 None +1 15.7 kB junderw

View full report↗︎

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (240e396) 74.11% compared to head (ec6442b) 74.09%.
Report is 1 commits behind head on main.

Files Patch % Lines
packages/core/src/validations.ts 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1667      +/-   ##
==========================================
- Coverage   74.11%   74.09%   -0.03%     
==========================================
  Files          98       98              
  Lines        9021     9032      +11     
  Branches     2010     2012       +2     
==========================================
+ Hits         6686     6692       +6     
- Misses       2223     2228       +5     
  Partials      112      112              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanjayprabhu sanjayprabhu merged commit 763d315 into farcasterxyz:main Feb 7, 2024
10 checks passed
@sanjayprabhu sanjayprabhu deleted the verification_rename branch February 7, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-feat Add a new feature or protocol improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant