fix: don't force fetch message count for non-existent fids #1653
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Since we're populating the storage cache from messages in the db, fids without any storage are undefined, and the prune job is causing db fetches for fids with no storage. Save some db calls when pruning fids with no storage.
Change Summary
Describe the changes being made in 1-2 concise sentences.
Merge Checklist
Choose all relevant options below by adding an
x
now or at any time before submitting for reviewAdditional Context
If this is a relatively large or complex change, provide more details here that will help reviewers
PR-Codex overview
Focus of the PR:
The focus of this PR is to add an optional parameter
forceFetch
to thegetMessageCount
andgetCacheMessageCount
functions in order to control whether to fetch the message count or not.Detailed summary:
forceFetch
parameter to thegetMessageCount
function instorageCache.ts
forceFetch
parameter to thegetCacheMessageCount
function instoreEventHandler.ts
getCacheMessageCount
instore.ts
to include theforceFetch
parameter