Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't force fetch message count for non-existent fids #1653

Merged

Conversation

sanjayprabhu
Copy link
Contributor

@sanjayprabhu sanjayprabhu commented Feb 5, 2024

Motivation

Since we're populating the storage cache from messages in the db, fids without any storage are undefined, and the prune job is causing db fetches for fids with no storage. Save some db calls when pruning fids with no storage.

Change Summary

Describe the changes being made in 1-2 concise sentences.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

Additional Context

If this is a relatively large or complex change, provide more details here that will help reviewers


PR-Codex overview

Focus of the PR:

The focus of this PR is to add an optional parameter forceFetch to the getMessageCount and getCacheMessageCount functions in order to control whether to fetch the message count or not.

Detailed summary:

  • Added forceFetch parameter to the getMessageCount function in storageCache.ts
  • Added forceFetch parameter to the getCacheMessageCount function in storeEventHandler.ts
  • Modified the usage of getCacheMessageCount in store.ts to include the forceFetch parameter

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Feb 5, 2024

⚠️ No Changeset found

Latest commit: af77e78

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2024 0:50am

@sanjayprabhu sanjayprabhu added the t-perf Improve performance label Feb 5, 2024
@sanjayprabhu sanjayprabhu marked this pull request as ready for review February 5, 2024 16:26
@sanjayprabhu sanjayprabhu merged commit d3cd9c9 into farcasterxyz:main Feb 5, 2024
8 checks passed
@sanjayprabhu sanjayprabhu deleted the fix_storage_cache_thrash branch February 5, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-perf Improve performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant