Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable codecov #19

Merged
merged 2 commits into from
Feb 18, 2025
Merged

chore: enable codecov #19

merged 2 commits into from
Feb 18, 2025

Conversation

nico-famedly
Copy link
Member

Currently only uploads coverage for the unittests run via trial. In theory we could calculate coverage also from sytest and complement.

The builtin coverage of trial tends to error out when trying to calculate the coverage of the html files, because it doesn't distinguish which files got opened. For this reason we are using coverage.py, but that doesn't work when using multiple trial jobs in parallel (unless putting in additional work), so this currently uses no concurrency.

I disabled some jobs around the rust parts of synapse for now as those would take more work to set up.

Currently only uploads coverage for the unittests run via trial. In
theory we could calculate coverage also from sytest and complement.

The builtin coverage of trial tends to error out when trying to
calculate the coverage of the html files, because it doesn't distinguish
which files got opened. For this reason we are using coverage.py, but
that doesn't work when using multiple trial jobs in parallel (unless
putting in additional work), so this currently uses no concurrency.

I disabled some jobs around the rust parts of synapse for now as those
would take more work to set up.
Copy link

codecov bot commented Feb 18, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Copy link

@jason-famedly jason-famedly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Let's go with it

@nico-famedly nico-famedly merged commit 401b785 into master Feb 18, 2025
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants