-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore receiver_waker_size test since it's unstable #53
Conversation
d018418
to
cbb0dfc
Compare
So annoying that to run Will work around this by simply not running the tests on the MSRV version of Rust for this library. Verifying it via just |
cbb0dfc
to
d49da88
Compare
Couldn't you do something like this? [target.'cfg(not(test))'.dev-dependencies]
criterion = "0.5.1" |
144299c
to
e694a51
Compare
That is sadly not possible. Quoting https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#platform-specific-dependencies
|
c66a944
to
e2a2cdb
Compare
But I solved it with a hack similar to the I should note that Rust 1.65 is very old! And I'm by no means a strict MSRV advocate. I'd happily be supporting |
e2a2cdb
to
46bbcbf
Compare
46bbcbf
to
2ccf485
Compare
I moved the criterion over to #54, to not mix different tasks up in one PR. Now this very simple ignore-PR can pass cleanly. |
At first I just updated the sizes to match stable Rust 1.84. But I then realized the size of
Thread
was smaller again on nightly. So let's ignore the test for now and see what the standard library settles on, if anything stable at all. The standard library give no size guarantees about the struct we are testing the size of, so this test is inherently unstable! The problem lies in this library, not instd
. I just want to have this test in place to catch library bugs that cause theReceiverWaker
to blow up in size unintentionally.The Rust PR that reverted the size increase of
std::thread::Thread
, and made it go back to pre Rust 1.84 sizes is this one: rust-lang/rust#132654