[FIX] account_payment_order: Check correctly for duplicated lines on … #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljsalvatierra-factorlibre
requested changes
Apr 17, 2024
| for pay_line in order.payment_line_ids: | ||
| move_line = pay_line.move_line_id | ||
| if move_line in found_lines: | ||
| raise ValidationError(_("Duplicated lines found.")) |
There was a problem hiding this comment.
Mostraría más información del error, indicando la orden de pago y las líneas implicadas.
…payment order constraint
aritzolea
force-pushed
the
16.0-imp-account_payment_order-constraint_fix
branch
from
bd8fe66 to
0296ce9
Compare
|
Cierro PR, y llevo los cambios directamente al PR original al no afectar a nuestro common |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…payment order constraint
Algoritmo con complejidad lineal para detectar si hay líneas duplicadas