[16.0][FIX] account_payment_return: Set is_exchange to False, we only need to initialize the key, its being calculated later in _compute_payments_widget_reconciled_info #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to initialize the key, its being calculated later in _compute_payments_widget_reconciled_info
sergiobstoj
changed the title
ljsalvatierra-factorlibre
approved these changes
Dec 12, 2024
sergiobstoj
pushed a commit
that referenced
this pull request
Jan 14, 2025
This is a minor fix in the manifest.py file of account_cash_invoice: Change category from "Account" to "Accounting" in order to follow the categories set in Odoo 11 Change the website to the repository web https://github.com/OCA/account-payment Remove the lines # -- coding: utf-8 --
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to PR 767
If we set
"is_exchange": False, is not changing the goal of the original PR._compute_payments_widget_reconciled_infomethod inaccount_payment_returnmodule makes a call toprepare_values_returned_widgetand then goes tosuper().In
super(),_compute_payments_widget_reconciled_infocore method is updating the value ofis_exchange.So the proposal review in original PR is Ok, as we avoid
is_exchangecalculation twice.