-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Load CLR with Python.NET #421
feat: Load CLR with Python.NET #421
Conversation
both failed actions look like authorization issue. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check unit tests as I’ve now added an ARM64 runner for checks that are currently failing. It may be, that this more ideal Python.NET find_dotnet_root()
utility isn’t actually working yet, for this situation.
@DaveSkender Looks like the failed tests were false negatives for some reason. I re-run all tests and it all passed. Does it all passed before this PR? yah, all green in my last couple PRs and on |
The root problem was my virtual environment on my local machine is on M1 Rosetta mode though. This proves the need that we should load clr through |
I'm wondering if the root problem from #408 was actually with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just re-request a Review when you want me to look at this again. I'm not sure if you'd intended to or are interested in checking out these two open topics:
- Typings issue with
clr
.NET members, even if just dev env problem? - Broken
venv
handling, or if that's even related to our code.
@DaveSkender Sorry, I made you confused. The reason for #408:
The reason for error on my virtual env:
So there was two different issues and |
I don't think we need a bulid test for |
@DaveSkender |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, intuitively. One thing I'll want to check is whether macOS with just .NET 9 still works. The GitHub runners have .NET 8 and .NET 9 installed, so we many not be getting an entirely pure test on that scenario.
In my head, I'm still confused by some of this -- if we rollback the changes I made to fix a problem; how is it that the problem is still solved? Is it the Assembly.LoadFile()
was the fix, and other stuff was unneeded -- I think that's what you're saying, which makes sense. I ran into multiple issues in debugging, so I may have fixed an intermediate problem that wasn't needed after I'd fixed something else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I understand this better now, and was able to run in on a macOS with just .NET 9 installed.
changes
Load CLR with Python.NET
Implement
Fix: Load CLR with Python.NET #420