-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Retain timezone awareness #410
Draft
DaveSkender
wants to merge
26
commits into
main
Choose a base branch
from
DaveSkender/retain-timezone
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
bb1df51
fix: Retain timezone awareness
DaveSkender 8558dfb
Update `_get_date` and `_set_date` methods to handle timezone-aware d…
DaveSkender dfbad48
Update `_set_date` function to handle timezone information in `quote.py`
DaveSkender 305b8e3
Update `DateTime` class and `test_quote_constructor_retains_timezone`…
DaveSkender d6e1bbe
e15697c
Update `_get_date` and `_set_date` functions to handle timezone-aware…
DaveSkender 963abe4
isolate location of conversion
DaveSkender 355241a
Update `DateTime` class and `to_pydatetime` function to handle timezo…
DaveSkender c4b5d70
Update `DateTime` class and `to_pydatetime` function to handle timezo…
DaveSkender be18867
Update `DateTime` class and `to_pydatetime` function to preserve time…
DaveSkender d08c3e5
Update `DateTime` class and `to_pydatetime` function to handle timezo…
DaveSkender 44162a3
Update `DateTime` class and `Quote` class to handle timezone-aware da…
DaveSkender 06305e4
Update `DateTime` class and `to_pydatetime` function to handle timezo…
DaveSkender bc8c0b5
Update `_get_date` and `_set_date` functions in `quote.py` to handle …
DaveSkender 572cab0
add devcontainer
DaveSkender 9f81b5d
update dev container
DaveSkender 3bdb39b
Update `_set_date` function to handle timezone-aware datetime objects…
DaveSkender c07b38e
Update `DateTime` class to retain timezone information
DaveSkender fd70f30
Update `devcontainer.json` to include GitHub Copilot extension
DaveSkender 8a6cb26
Update test cases to handle timezone-aware datetime objects
DaveSkender 31d214b
Merge branch 'main' into DaveSkender/retain-timezone
DaveSkender 8794fa8
Merge branch 'main' into DaveSkender/retain-timezone
DaveSkender ae22ee7
Update tests/common/test_cstype_conversion.py
DaveSkender 73b3aeb
Related to #409
DaveSkender 309202d
Merge branch 'main' into DaveSkender/retain-timezone
LeeDongGeon1996 dbca91d
Merge branch 'main' into DaveSkender/retain-timezone
DaveSkender File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
o
format won't work according to #310