fix: Retain timezone awareness #410
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #409 Modify the `DateTime` class in `stock_indicators/_cstypes/datetime.py` to use `datetime.isoformat(timespec='seconds')` to retain timezone information. Update the `to_pydatetime` function in `stock_indicators/_cstypes/datetime.py` to handle timezone information correctly. Add a test in `tests/common/test_cstype_conversion.py` to verify that the `Quote` constructor retains timezone information. * Add `test_quote_constructor_retains_timezone` method to test the `Quote` constructor with timezone-aware datetime objects. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/facioquo/stock-indicators-python/issues/409?shareId=XXXX-XXXX-XXXX-XXXX).
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
…atetime objects * Add a check in `_set_date` to convert timezone-aware datetime objects to UTC
* Import `timezone` from `datetime` * Check if `value` has timezone information and convert it to UTC if it does * Ensure `quote.Date` is set to `CsDateTime(value)`
… method to handle timezone-aware datetime objects * **`stock_indicators/_cstypes/datetime.py`** - Update `DateTime` class to convert timezone-aware datetime objects to UTC - Update `to_pydatetime` function to retain timezone information when converting C# `System.DateTime` objects back to Python `datetime` objects * **`tests/common/test_cstype_conversion.py`** - Add `test_quote_constructor_retains_timezone` method to verify the retention of timezone information in the `Quote` constructor
… datetime objects * Add a check in `_set_date` to convert timezone-aware datetime objects to UTC before setting the `Date` property
…ne-aware datetime objects * Preserve timezone information when converting Python `datetime` objects to C# `System.DateTime` objects * Handle timezone-aware datetime objects when converting C# `System.DateTime` objects to Python `datetime` objects * Ensure type object `datetime.datetime` has attribute `timezone` if missing Add test cases to verify handling of various date formats in `Quote` class * Add `test_quote_constructor_handles_various_date_formats` method to verify retention of timezone information in `Quote` constructor * Add test cases to verify `Quote` class can handle various date formats
…ne-aware datetime objects * Preserve timezone information when converting Python `datetime` objects to C# `System.DateTime` objects * Handle timezone-aware datetime objects when converting C# `System.DateTime` objects to Python `datetime` objects * Ensure type object `datetime.datetime` handles scenarios where attribute `timezone` is missing Update `_get_date` and `_set_date` functions in `Quote` class to handle timezone-aware datetime objects * Handle timezone-aware datetime objects without normalizing them to UTC * Ensure `Quote` class can handle timezone-aware datetime objects when initializing and setting the `date` property Add tests for timezone handling in `Quote` class * Add `test_quote_constructor_retains_timezone` to verify retention of timezone information in `Quote` constructor * Add test cases to verify `Quote` class and related functions can handle various date formats
…zone information * Update `DateTime` class to preserve timezone information when converting Python `datetime` objects to C# `System.DateTime` objects * Update `to_pydatetime` function to handle different date formats and retain timezone information when converting C# `System.DateTime` objects to Python `datetime` objects * Add `test_quote_constructor_handles_various_date_formats` method to verify that the `Quote` class can handle various date formats
…ne information * Preserve timezone information when converting Python `datetime` objects to C# `System.DateTime` objects * Handle different date formats and retain timezone information when converting C# `System.DateTime` objects to Python `datetime` objects * Avoid setting the timezone attribute directly on the datetime class and handle timezone-aware datetime objects correctly using existing methods
…tetime objects * **`stock_indicators/_cstypes/datetime.py`** - Remove timezone normalization to UTC in `DateTime` class - Preserve timezone information when converting Python `datetime` objects to C# `System.DateTime` objects * **`stock_indicators/indicators/common/quote.py`** - Add timezone handling in `_set_date` function to convert to UTC if timezone-aware - Ensure `Quote` class handles timezone-aware datetime objects without normalizing to UTC
…ne information and various date formats * **DateTime class**: - Preserve timezone information when converting Python `datetime` objects to C# `System.DateTime` objects - Avoid setting the timezone attribute directly on the datetime class * **to_pydatetime function**: - Handle different date formats and retain timezone information when converting C# `System.DateTime` objects to Python `datetime` objects * **Tests**: - Add `test_quote_constructor_retains_timezone` method to verify retention of timezone information in the `Quote` constructor - Add `test_quote_constructor_handles_various_date_formats` method to verify handling of various date formats in the `Quote` class
…timezone-aware datetime objects * Add check for `tzinfo` attribute in `_set_date` function and adjust timezone accordingly * Modify test cases in `test_cstype_conversion.py` to verify correct handling of timezone information in `Quote` constructor
… and convert them to UTC * Remove unnecessary timezone conversion logic
* Remove unnecessary timezone conversion in `__new__` method
* Add "github.copilot" to the extensions list * Update the `test` task to use single quotes instead of double quotes * Ensure the Dockerfile supports all the dependencies required by GitHub Copilot Update `quote.py` to handle timezone-aware datetime objects * Modify `_get_date` and `_set_date` functions to handle timezone-aware datetime objects and convert them to UTC Update `datetime.py` to retain timezone information * Update `DateTime` class to retain timezone information when converting Python `datetime` objects to C# `System.DateTime` objects * Update `to_pydatetime` function to retain timezone information when converting C# `System.DateTime` objects back to Python `datetime` objects Update `test_quote.py` to verify timezone retention * Add `test_quote_constructor_retains_timezone` method to verify the retention of timezone information in the `Quote` constructor * Add `test_quote_constructor_handles_various_date_formats` method to verify that the `Quote` class can handle various date formats
* **test_cstype_conversion.py**: Remove unused `timezone` import in `test_quote_constructor_retains_timezone` and `test_quote_constructor_handles_various_date_formats` methods. * **test_quote.py**: Remove unused `timezone` import in `test_quote_constructor_retains_timezone` and `test_quote_constructor_handles_various_date_formats` methods. Add blank lines for better readability.
Signed-off-by: Dave Skender <8432125+DaveSkender@users.noreply.github.com>
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
|
@LeeDongGeon1996 this is still essentially broken. I'll keep working on it, but I could use another set of eyes reviewing it too if you have a chance. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Dave Skender <8432125+DaveSkender@users.noreply.github.com>
Modify `DateTime` class to use `datetime.isoformat(timespec='seconds')` to retain timezone information Update `to_pydatetime` function to handle timezone information correctly Add tests to verify that the `Quote` constructor retains timezone information * Add `test_quote_constructor_retains_timezone` method to `TestCsTypeConversion` class * Import `Quote` class from `stock_indicators.indicators.common.quote` * Add assertions to check timezone and time of `Quote` date --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/facioquo/stock-indicators-python/pull/410?shareId=XXXX-XXXX-XXXX-XXXX).
DaveSkender
commented
Feb 12, 2025
| @@ -30,4 +30,4 @@ def to_pydatetime(cs_datetime: CsDateTime) -> PyDateTime: | |||
| Parameter: | |||
| cs_datetime : `System.DateTime` of C#. | |||
| """ | |||
| return PyDateTime.fromisoformat(cs_datetime.ToString("s", CsCultureInfo.InvariantCulture)) | |||
| return PyDateTime.fromisoformat(cs_datetime.ToString("o", CsCultureInfo.InvariantCulture)) | |||
There was a problem hiding this comment.
o format won't work according to #310
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #409
Modify the
DateTimeclass instock_indicators/_cstypes/datetime.pyto usedatetime.isoformat(timespec='seconds')to retain timezone information.Update the
to_pydatetimefunction instock_indicators/_cstypes/datetime.pyto handle timezone information correctly.Add a test in
tests/common/test_cstype_conversion.pyto verify that theQuoteconstructor retains timezone information.test_quote_constructor_retains_timezonemethod to test theQuoteconstructor with timezone-aware datetime objects.For more details, open the Copilot Workspace session.