Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to support HuggingFace #2

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

thunn
Copy link

@thunn thunn commented Feb 12, 2025

Hi there 👋,

Awesome work to everyone involved in producing this model! It's always great to have more open-source speech/audio quality predictors to experiment with!

I had seen the issue regarding onboarding this model to HF and spent some time making some initial steps. I wanted to get some feedback from you at this stage before I go any further. I have added some tooling to make things easier on my end, but I am more than happy to roll any of that back if needed.

Additions

  • Added a modified inference.py module with the AudioBoxAesthetics class, which supports saving/loading from Hugging Face + predicting from both WAV and JSONL formats.
  • Added a script to upload the model to the HF hub: src/audiobox_aesthetics/export_model_to_hf.py.
  • Added some basic tests to compare against the CLI method on sample audio (these are passing locally but not in GitHub workflows).
  • Uploaded the model to the HF hub – currently hosted thunnai/audiobox-aesthetics.
  • Added a Gradio demo: src/audiobox_aesthetics/demo.py (currently hosted here).
  • Added uv for dependency lock.

Also, check out the example scripts in examples.

Todo:

  • Update the README with examples.
  • Fix tests running in the GitHub workflow.

Thanks again for your contributions to open-source audio models!

I am more than happy to discuss any changes you would like to see in this PR.

All the best,
Tom 🚀

@facebook-github-bot
Copy link

Hi @thunn!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Feb 12, 2025
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@thunn
Copy link
Author

thunn commented Feb 13, 2025

@androstj @NielsRogge

Hey there,
Just wanted to flag this PR: Update to support HuggingFace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants